Skip to content

feat(CondensedMatter): the open tight binding chain is the hopping of the path graph - #2096

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-chain-adjacency
Nov 16, 2026
Merged

jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-chain-adjacency

Conversation

@naype888-cloud

Copy link
Copy Markdown
Contributor

Hi @jstoobysmith,

I've been thinking a lot about your last suggestion to add single lemmas that are easy for everyone to verify.

So I clarified the open tight binding chain into a single lemma: the open chain Hamiltonian is directly the hopping Hamiltonian of the path graph.

The lemma inner_openHamiltonian_eq_adjMatrix proves that the matrix elements between two sites are E0 times the identity minus t times the adjacency matrix of SimpleGraph.pathGraph T.N:

2842452\langle m | H_{\text{open}} | n \rangle = E_0 \cdot \mathbb{I}{mn} - t \cdot A(P_N){mn}2842452

  • Single lemma (Gate 7): Exactly +17 lines diff.
  • Direct from Mathlib: Uses standard Mathlib definitions (SimpleGraph.pathGraph, adjMatrix), so it does not need external bibliographic chasing.
  • CI / Linters: Verified locally with lake build -KCI --iofail and all 14 linters passing with 0 errors.

What do you think about it? Does it look good to you?

…e path graph

The matrix elements of the open chain Hamiltonian are E0 times the identity
minus t times the adjacency matrix of the path graph.
@github-actions github-actions Bot added small PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

While you wait for a review, note that you can review PRs too; reviewing is not restricted to maintainers. Our review guidelines explain what to look for.

Over time, contributions such as reviews, maintenance and documentation are recorded on contributions.physlib.io.

Three main points:

  • Comment -awaiting-author on its own line to remove that label from your PR.
  • Comment blocked-by-PR or -blocked-by-PR on its own line to add or remove that label, respectively.
  • The first review might take several days to arrive. If in doubt message on the Zulip.

For the author: Please read

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your changes.

If you have any problems or questions, please reach out to the community on the Zulip.

For reviewers: Summary of your PR

Found differences:
@@ PhyslibAlpha.CondensedMatter.TightBindingChain.Open.Basic @@
! module modified PhyslibAlpha.CondensedMatter.TightBindingChain.Open.Basic (+17 -0)
  namespaces CondensedMatter, CondensedMatter.TightBindingChain
+ added lemma inner_openHamiltonian_eq_adjMatrix
2 differences

The declarations are found by reading the diff as text, without regard for namespaces, so a declaration whose keyword and name are on different lines is missed, and two declarations of the same name in different namespaces are listed as one. A change to a proof, or to the body of a definition, does not appear. See scripts/alpha/github/pr_summary.lean.

Summary of commit 3056086, remade whenever a commit is pushed.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - will merge now

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Nov 16, 2026
@jstoobysmith
jstoobysmith added this pull request to the merge queue Nov 16, 2026
Merged via the queue into leanprover-community:master with commit 3d9ca09 Nov 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants